CI: use codecov/codecov-action #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use codecov/codecov-action instead of the codecov CLI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3986 +/- ##
=======================================
Coverage 85.39% 85.39%
=======================================
Files 235 235
Lines 56628 56628
=======================================
Hits 48358 48358
Misses 8270 8270 ☔ View full report in Codecov by Sentry. |
masatake
approved these changes
Apr 18, 2024
|
Thank you very much. |
k-takata
commented
Apr 18, 2024
|
I've removed the old settings for codecov CLI and for coveralls. @masatake Do you think it's okay? |
k-takata
force-pushed
the
use-codecov-action
branch
2 times, most recently
from
cda666f
to
4d16235
Compare
|
I tried to remove lcov, but it didn't work well. It seems that lcov is still needed even with codecov/codecov-action. |
* Remove old settings for the codecov CLI. * Remove old settings for coveralls.
k-takata
force-pushed
the
use-codecov-action
branch
from
4d16235
to
7be24dc
Compare
masatake
approved these changes
Apr 18, 2024
|
Everything reducing the maintenance cost of the files under .github/workflow is acceptable in this area! |
|
Thank you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use codecov/codecov-action instead of the codecov CLI.