Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate upstream test suite #1

Closed
jonashaag opened this issue May 9, 2016 · 5 comments
Closed

Integrate upstream test suite #1

jonashaag opened this issue May 9, 2016 · 5 comments

Comments

@jonashaag
Copy link
Collaborator

I added a new test suite under the tests/ directory; however I just noticed there's a test suite under src/tests/. Merge the two and integrate them into Travis.

@sbraz
Copy link
Collaborator

sbraz commented May 9, 2016

I'll do it :)

@jonashaag
Copy link
Collaborator Author

👍

@jonashaag
Copy link
Collaborator Author

jonashaag commented May 9, 2016

I'll give you commit permissions in a sec

Edit: Done, feel free to do other improvements to the project if you want

@sbraz
Copy link
Collaborator

sbraz commented May 9, 2016

I wouldn't mind a bit of feedback on my changes first, I'm not really
experienced with tests.

On 9 May 2016 at 14:50, Jonas Haag notifications@github.com wrote:

I'll give you commit permissions in a sec


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1 (comment)

@jonashaag
Copy link
Collaborator Author

Sure, you can still do a PR and gather some feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants