Receive events from Marathon & relay events to Consul. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miltontony & @Rizziepit first PR ready for review. Bare bones relay of events from Marathon to Consul, ignores any staging flags at this point. Next PR addresses flags. |
|
Marathon events documented here: https://mesosphere.github.io/marathon/docs/event-bus.html |
|
@bruskiza also pinging you, ready for review. |
|
Oops, merged #3 into this one. |
| self.event_dispatch = { | ||
| 'status_update_event': self.handle_status_update_event, | ||
| } | ||
| self.unknown_event_handler = self.handle_unknown_event |
There was a problem hiding this comment.
I'm wondering why the rename here? I see handle_unknown_event being used below but not unknown_event_handler.
There was a problem hiding this comment.
Good catch, thought I needed to mock this out for tests, turns out not needed.
|
👍 looks good |
|
+1 from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.