Refactor all HTTP requests into client classes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Let JsonClient._log_http_error handle everything
* Keep a default endpoint in the base class, add a kwarg for specifying a different endpoint. * Add get_json() method to perform a GET request expecting a JSON response.
* Move new Consul get k/v method to client
* Only try get JSON content if OK response code * Add new UnexpectedResponseError type * Handle 404's that should be ignored in main Consular class * Add tests
|
ping 🔔 |
| Get the response JSON content if the respones code is OK (200), else | ||
| raise an `UnexpectedResponseError`. | ||
| """ | ||
| if response.code == OK: |
There was a problem hiding this comment.
The full range of 2xx is essentially OK, does OK cover these?
There was a problem hiding this comment.
It doesn't look like it http://twistedmatrix.com/trac/browser/tags/releases/twisted-15.4.0/twisted/web/_responses.py
|
👍 |
JayH5
added a commit
that referenced
this pull request
Oct 19, 2015
Refactor all HTTP requests into client classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #35, comparing against
developthis time.