Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sanity checks/simplifications around key deletion #40

Merged
merged 3 commits into from
Oct 19, 2015

Conversation

JayH5
Copy link
Contributor

@JayH5 JayH5 commented Oct 19, 2015

No description provided.

@@ -413,6 +419,8 @@ def get_consul_consular_keys(self):
def delete_consul_kv_keys(self, keys, recurse=False):
""" Delete a sequence of Consul k/v keys. """
for key in keys:
log.msg('Deleting Consul k/v key "%s", recursively? %s' % (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a question?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll look like Deleting Consul k/v key "my-app", recursively? True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) cool

@miltontony
Copy link

👍

JayH5 added a commit that referenced this pull request Oct 19, 2015
Some sanity checks/simplifications around key deletion
@JayH5 JayH5 merged commit ab89b95 into develop Oct 19, 2015
@JayH5 JayH5 deleted the feature/adhoc-more-inline branch October 19, 2015 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants