Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept non-200 code responses #44

Merged
merged 1 commit into from
Oct 20, 2015
Merged

Accept non-200 code responses #44

merged 1 commit into from
Oct 20, 2015

Conversation

JayH5
Copy link
Contributor

@JayH5 JayH5 commented Oct 20, 2015

At the moment we only accept 200 response codes but other 2xx codes are acceptable too.

Do something like requests: https://github.com/kennethreitz/requests/blob/v2.8.1/requests/models.py#L825-L837

* Copy code from requests (as a callback)
* Raise exception for all calls (not just get_json())
@smn
Copy link
Contributor

smn commented Oct 20, 2015

👍

JayH5 added a commit that referenced this pull request Oct 20, 2015
@JayH5 JayH5 merged commit 7d50ae6 into develop Oct 20, 2015
@JayH5 JayH5 deleted the feature/issue-44-non-200 branch October 20, 2015 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants