Consular crashes if a Marathon task has no ports #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If 0 ports, don't specify a port for the Consul service * If more than 1 port, use the lowest port
* Fixes pypy tests also just a better way to do things
|
Ready for review. I'm not tackling multiple ports at the moment because that's significantly more complicated. Will leave up to #29. |
| [port] = ports | ||
| else: | ||
| # TODO: Support multiple ports (issue #29) | ||
| port = sorted(ports)[0] |
|
👍 and nice job on splitting it up like this. |
JayH5
added a commit
that referenced
this pull request
Oct 28, 2015
Consular crashes if a Marathon task has no ports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #29.
We hardcode it...
task['port'][0]