Skip to content

Commit

Permalink
Improve list builders, iteration and construction (#3419)
Browse files Browse the repository at this point in the history
* list namespace to polars-ops

* Improve list builders, iteration and construction

- Greatly improves performance of the list builders
 by: jorgecarleitao/arrow2#991

- List builders now also support nested dtypes like List and Struct

- Python DataFrame and Series constructor now support better nested dtype
construction

* fix tests and fix struct::agg_list
  • Loading branch information
ritchie46 committed May 18, 2022
1 parent e45a12d commit 8bae819
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nodejs-polars/src/list_construction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ pub fn js_arr_to_list(name: &str, arr: &Array, dtype: &DataType) -> napi::Result
builder.finish().into_series()
}
DataType::Datetime(_, _) => {
let mut builder = ListPrimitiveChunkedBuilder::<i64>::new(
let mut builder = ListPrimitiveChunkedBuilder::<Int64Type>::new(
name,
len as usize,
(len as usize) * 5,
Expand Down

0 comments on commit 8bae819

Please sign in to comment.