Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added enableWiFiAtBootTime() to enable legacy wifi persistence #513

Merged
merged 1 commit into from Jun 18, 2021
Merged

Added enableWiFiAtBootTime() to enable legacy wifi persistence #513

merged 1 commit into from Jun 18, 2021

Conversation

peterschrott
Copy link
Contributor

Fixing issue: #507

From version 3 of Arduino core (ESP8266Wifi) the persistence of wifi settings has changed.
Source: https://arduino-esp8266.readthedocs.io/en/latest/esp8266wifi/generic-class.html#persistent

Adding enableWiFiAtBootTime() restores the legacy behavior.

@peterschrott peterschrott marked this pull request as draft June 16, 2021 08:12
@peterschrott peterschrott marked this pull request as ready for review June 16, 2021 08:13
Copy link
Owner

@universam1 universam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@universam1
Copy link
Owner

good discovery, thank you @peterschrott

@universam1 universam1 merged commit 7f82a04 into universam1:master Jun 18, 2021
@tjhowse
Copy link

tjhowse commented Jun 23, 2021

Can confirm - My Wemos D1 mini based iSpindel stopped automatically connecting to wifi after deep sleep after I upgraded it to v7.0.0. I built and flashed v7.1.0 and now it's back to normal. Thanks @peterschrott !

@peterschrott
Copy link
Contributor Author

@tjhowse ur welcome.
But there is not "official" 7.1.0. @universam1 when do you release a new fw?

@tjhowse
Copy link

tjhowse commented Jun 23, 2021

I'm just a user, not a maintainer. I don't know when v7.1.0 is going to be promoted from beta.

@peterschrott
Copy link
Contributor Author

Question was going out to the maintainer. But just saw the "pre-release" now.
Great! I need to brew soon! :)

@tjhowse
Copy link

tjhowse commented Jun 23, 2021

Oh sorry! I didn't notice your maintainer @mention. Now I feel silly 😆

@universam1
Copy link
Owner

Didn't have time to test it yet, but based on positive feedback I can promote it to be a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants