Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tilt angle independent of the board orientation #531

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

m0n5t3r
Copy link
Contributor

@m0n5t3r m0n5t3r commented Aug 12, 2021

this solves #445 (yes, the calibration will account for the weird numbers, but it's nice to have a number one can relate to - for instance, instructions say the 1.000 angle should be 25 degrees - with the board inverted that would be 155 degrees, having to remember to subtract from 180 degrees is less than ideal :) )

@ErikdBr
Copy link
Contributor

ErikdBr commented Aug 13, 2021

Wasn't this already resolved in 6.5.1 ?

@m0n5t3r
Copy link
Contributor Author

m0n5t3r commented Aug 13, 2021

apparently not; I updated my ispindels a few months ago and only got to use one recently; initially I thought I calibrated it wrong or something, but then I did the trig on paper and it checked out (negative z will result in the supplementary angle, i.e. 180 - our tilt angle)

Copy link
Owner

@universam1 universam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@universam1
Copy link
Owner

Thanks for that

@universam1 universam1 merged commit 39f0751 into universam1:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants