In map_entry use find_resource to conditionally create the automaster_entry
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if it does not exist. It may have been previously created with options (i.e. timeout) and unconditionally creating it will cause the options to be undone.
|
Is there anything else needed to get this merged? |
|
Thanks Joe. That's all merged and uploaded to the Supermarket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
map_entryuse find_resource to create theautomaster_entryonlyif it does not exist. It may have been previously created with options
(i.e. timeout) and unconditionally creating it will cause the options
to be undone.