Сделал метод place_bet для betclub2 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
feat(base/session) |
loyd
requested changes
Oct 3, 2016
| let event = state.events.iter().find(|e| e.Id == offer.inner_id as u32).unwrap(); | ||
| let market = event.get_market().unwrap(); | ||
|
|
||
| let basket = if outcome.0 == event.TeamsGroup[0] {&market.Rates[0].AddToBasket} |
There was a problem hiding this comment.
Как это можно на match переписать?
There was a problem hiding this comment.
event.TeamsGroup[..] не константа, так что никак
| }}"#, | ||
| event_id = basket.eId, | ||
| bet_id = basket.bId, | ||
| hand_size = match basket.fs { Some(v) => v.to_string(), _ => "null".to_string() }, |
| return Err(Error::from(format!("Could not place a bet: {}", string))); | ||
| } | ||
|
|
||
| Ok(()) | ||
| } | ||
| } |
There was a problem hiding this comment.
У тебя short polling, так что ещё реализовать check_offer нужно
| try!(response.read_to_string(&mut string)); | ||
|
|
||
| if !string.contains("AmountIn") { | ||
| return Err(Error::from(format!("Could not place a bet: {}", string))); |
There was a problem hiding this comment.
Тут префикс could not place... Лишний, это задача вызывающей функции
There was a problem hiding this comment.
А ещё я думаю, что лучше From::from вместо Error::from, ибо испортить не надо и гибче. Это вопрос стиля, так что давай определимся
There was a problem hiding this comment.
Но и у Error::from преимущества. Как думаешь?
|
@loyd, обновил |
universome
force-pushed
the
feature/19-betclub2-placebet
branch
from
bd18f51
to
8e0d9a8
Compare
loyd
approved these changes
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #19