Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'deepencoding' architecture #32

Merged
merged 9 commits into from Dec 13, 2020
Merged

Remove 'deepencoding' architecture #32

merged 9 commits into from Dec 13, 2020

Conversation

VarIr
Copy link
Collaborator

@VarIr VarIr commented Dec 11, 2020

Initially, the working title of the main deep network architecture used in deepnog was deepencoding.
For the paper, we switched to calling this DeepNOG, similar to the program itself.
This PR removes deepencoding altogether in order to avoid confusion about naming.

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #32 (21cd493) into master (d62d350) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   96.92%   96.72%   -0.20%     
==========================================
  Files          37       36       -1     
  Lines        2112     2045      -67     
==========================================
- Hits         2047     1978      -69     
- Misses         65       67       +2     
Impacted Files Coverage Δ
deepnog/client/client.py 96.93% <ø> (-1.23%) ⬇️
deepnog/data/dataset.py 97.81% <ø> (ø)
deepnog/models/deepnog.py 96.92% <ø> (ø)
deepnog/tests/tests/test_utils.py 100.00% <ø> (ø)
deepnog/utils/io_utils.py 100.00% <ø> (ø)
deepnog/utils/network.py 91.22% <ø> (-3.51%) ⬇️
deepnog/utils/tests/test_imports.py 100.00% <ø> (ø)
deepnog/client/tests/test_cli.py 99.37% <100.00%> (ø)
deepnog/learning/tests/test_inference.py 100.00% <100.00%> (ø)
deepnog/models/__init__.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23bee4...21cd493. Read the comment docs.

Enable continuous integration for Linux and macOS builds with Github Actions.
This will consequently replace Travis CI, which limited access dramatically in Nov 2020.
Phasing out Travis CI in favour of Github Actions.
Windows builds on AppVeyor remain unaffacted for the time being.
Copy link
Collaborator Author

@VarIr VarIr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmyself two days later

@VarIr VarIr merged commit 16e5215 into master Dec 13, 2020
@VarIr VarIr deleted the remove_deepencoding branch December 13, 2020 08:38
@VarIr VarIr restored the remove_deepencoding branch December 13, 2020 08:40
@VarIr VarIr deleted the remove_deepencoding branch December 13, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant