Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Not working with zimfw #4

Open
unixorn opened this issue Mar 19, 2022 · 3 comments
Open

[BUG] Not working with zimfw #4

unixorn opened this issue Mar 19, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@unixorn
Copy link
Owner

unixorn commented Mar 19, 2022

Describe the bug
Doesn't load completions with zimfw

To Reproduce

Add zmodule unixorn/1password-op.plugin.zsh to .zimrc, watch it not load the completions

@unixorn unixorn added the bug Something isn't working label Mar 19, 2022
@lrosenman
Copy link

trying to just source the plugin doesn't work either.

If I add this line to my .zshrc it works:
eval "$(op completion zsh)"; compdef _op op

No clue why this doesn't work. :(

@psnelgrove-r7
Copy link

I was playing around with getting rid of oh-my-zsh because it was a drag on my terminal load times. I ran into this same error once I removed it.

My first guess was that oh-my-zsh was doing something special setting up the compdef function. Sure enough I found this SO post.

https://unix.stackexchange.com/questions/339954/zsh-command-not-found-compinstall-compinit-compdef

I did the following and I'm up and running

autoload -Uz compinit
compinit
eval "$(op completion zsh)"; compdef _op op

@unixorn
Copy link
Owner Author

unixorn commented Aug 22, 2023

Thanks for the fix description, I have omz loading in my zgenom config. I'll take a look at it this weekend unless you open a PR first :-)

Repository owner deleted a comment from Arpitkandwal Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants
@unixorn @lrosenman @psnelgrove-r7 and others