Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more candidate directories to be added to $PATH #30

Merged
merged 5 commits into from Feb 27, 2022

Conversation

unixorn
Copy link
Owner

@unixorn unixorn commented Feb 27, 2022

Description

Type of changes

Checklist

  • All new and existing tests pass.
  • Any added/updated scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh and #!/bin/bash are allowed exceptions)
  • Added/updated scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No end-user should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that the link(s) in my PR are valid.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

- Check for `~/homebrew/bin` and `~/homebrew/sbin` to cope when homebrew
  is installed in a user's home directory. Closes #28
- While we're in there, check for `/usr/local/sbin`,
  `/opt/homebrew/sbin`, `/opt/local/sbin`, `~/bin` and `~/sbin`
  directories too.

Signed-off-by: Joe Block <jpb@unixorn.net>
Signed-off-by: Joe Block <jpb@unixorn.net>
@unixorn unixorn force-pushed the cope-with-brew-in-homedir branch 6 times, most recently from 2094969 to 558f8b4 Compare February 27, 2022 16:54
@github-actions
Copy link

github-actions bot commented Feb 27, 2022

Mega-Linter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.23s
✅ CREDENTIALS secretlint yes no 1.21s
✅ GIT git_diff yes no 0.01s
⚠️ MARKDOWN markdownlint 1 1 0.38s
✅ MARKDOWN markdown-link-check 1 0 1.04s
✅ MARKDOWN markdown-table-formatter 1 0 0.33s
❌ SPELL cspell 2 60 1.94s
✅ SPELL misspell 2 0 0.05s

See errors details in artifact Mega-Linter reports on GitHub Action page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Signed-off-by: Joe Block <jpb@unixorn.net>
@github-actions
Copy link

github-actions bot commented Feb 27, 2022

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.01s
✅ COPYPASTE jscpd yes no 1.26s
✅ CREDENTIALS secretlint yes no 1.06s
✅ GIT git_diff yes no 0.01s
⚠️ MARKDOWN markdownlint 1 1 0.42s
✅ MARKDOWN markdown-link-check 1 0 0.87s
✅ MARKDOWN markdown-table-formatter 1 0 0.34s
✅ SPELL misspell 3 0 0.05s
✅ YAML prettier 1 0 1.32s
✅ YAML v8r 1 0 1.5s
✅ YAML yamllint 1 0 0.17s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Signed-off-by: Joe Block <jpb@unixorn.net>
@unixorn unixorn merged commit 9cb5083 into main Feb 27, 2022
@unixorn unixorn deleted the cope-with-brew-in-homedir branch February 27, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plugin does not work properly if we change the destination of the homebrew installation
1 participant