Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support install for source options #126

Merged
merged 1 commit into from Dec 29, 2023
Merged

feat: support install for source options #126

merged 1 commit into from Dec 29, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Dec 29, 2023

πŸ”— Linked issue

#51

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a shortcut for install giget option. A layer extended with [name, { install: true }] will install it's dependencies

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 marked this pull request as ready for review December 29, 2023 23:44
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (6c09735) 76.83% compared to head (5ed62b3) 76.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   76.83%   76.89%   +0.05%     
==========================================
  Files           7        7              
  Lines         803      805       +2     
  Branches       80       80              
==========================================
+ Hits          617      619       +2     
  Misses        184      184              
  Partials        2        2              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 merged commit 45dc079 into main Dec 29, 2023
4 checks passed
@pi0 pi0 deleted the feat/install branch December 29, 2023 23:45
@pi0 pi0 mentioned this pull request Dec 29, 2023
1 task
@Marian-Calin-Stroescu-Fiskars

it looks like it is going in an infinite loop?

I am using nuxt to extend some layers:

  extends: [
    [
      `github:username/repo/path1#develop`,
      { install: true }
    ],
    [
      `github:username/repo/path2#develop`,
      { install: true }
    ],
    [
      `github:username/repo/path3#develop`,
      { install: true }
    ],
  ],

when i run install it throws this:

(node:37546) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 keypress listeners added to [Socket]. Use emitter.setMa…
β”‚ (Use `node --trace-warnings ...` to show where the warning was created)
β”‚ (node:37546) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 end listeners added to [Socket]. Use emitter.setMaxList…
β”‚ (node:37546) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [Socket]. Use emitter.setMaxLi…

@pi0
Copy link
Member Author

pi0 commented Jan 3, 2024

@Marian-Calin-Stroescu-Fiskars Would you please open a new issue with reproduction I can check? πŸ™πŸΌ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants