Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support different repository providers #55

Merged
merged 10 commits into from Mar 1, 2023
Merged

Conversation

dnldsht
Copy link
Contributor

@dnldsht dnldsht commented Nov 30, 2022

Introduced support for different git hosts and format references accordingly

Checking the specs for the repository field in package.json you can define different providers (github, gitlab, ...) so I've added the support for that and formatted the references (commit, pull-request, issue, compare) accordingly.

I've introduced a breaking change removing the github prop from the config, I can restore it and make it compatible with the new feature.

I'm really bad at naming :) I've used host I'm open for better name

I've also fixed 2 minor bugs:

  • broken ungh link
  • issue reference for github ssue -> issue

addeedd support for github, gitlab, bitbucket and selfhosted git hosts

removed github from config
@dnldsht
Copy link
Contributor Author

dnldsht commented Dec 6, 2022

@pi0 any comment about the PR?

@pi0
Copy link
Member

pi0 commented Feb 17, 2023

Hi dear @dnldsht sorry this was stalled. Do you mind to rebase your pull request?

@dnldsht
Copy link
Contributor Author

dnldsht commented Feb 17, 2023

Yess, I will sync my PR

@pi0 done

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #55 (6907566) into main (e162ab8) will increase coverage by 3.23%.
The diff coverage is 100.00%.

❗ Current head 6907566 differs from pull request most recent head c7ff326. Consider uploading reports for the commit c7ff326 to get more accurate results

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   80.84%   84.07%   +3.23%     
==========================================
  Files           5        6       +1     
  Lines         475      559      +84     
  Branches       64       80      +16     
==========================================
+ Hits          384      470      +86     
+ Misses         91       89       -2     
Impacted Files Coverage Δ
src/config.ts 91.76% <100.00%> (-0.10%) ⬇️
src/index.ts 100.00% <100.00%> (ø)
src/markdown.ts 96.59% <100.00%> (+0.86%) ⬆️
src/repo.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title feat: different git hosts support feat: support different repository providers Mar 1, 2023
@pi0 pi0 changed the title feat: support different repository providers feat!: support different repository providers Mar 1, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 0bb28ab into unjs:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants