feat: switch to smol-toml for toml parsing #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
N/A
β Type of change
π Description
The TOML parser currently in use, https://github.com/BinaryMuse/toml-node, only supports the 0.4.0 spec, and therefore has many open issues regarding unsupported features. On the other hand, https://github.com/squirrelchat/smol-toml supports the latest 1.0.0 spec and has zero spec-related issues open. In addition, I believe the performance is significantly better with
smol-toml
:If I'm reading that correctly, the current parser is 1.4 times slower than
smol-toml
!π Checklist