Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support minus infinity #67

Merged
merged 3 commits into from Jun 12, 2023
Merged

Conversation

zuixinwang
Copy link
Contributor

No description provided.

@zuixinwang zuixinwang changed the title feat: support negative infinity feat: support sign infinity Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #67 (1ef3ab2) into main (3968b6c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           55        56    +1     
  Branches        21        22    +1     
=========================================
+ Hits            55        56    +1     
Impacted Files Coverage 螖
src/index.ts 100.00% <100.00%> (酶)

@pi0 pi0 changed the title feat: support sign infinity feat: support minus infinity Jun 12, 2023
@pi0 pi0 merged commit 448a77d into unjs:main Jun 12, 2023
1 check passed
@zuixinwang
Copy link
Contributor Author

Should it support positive infinity with a positive sign? 馃憖
+infinity means Number.POSITIVE_INFINITY
@pi0

@pi0
Copy link
Member

pi0 commented Jun 13, 2023

I guess since we already support without + prefix, it is best to only support minus for best of performance, reducing one more if check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants