fix: don't override font-family: inherit
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding `font-family: inherit` to `font-family: inherit, "inherit override"` leads to an invalid property value. This commit attempts to fix this by skipping overrides if the first family is 'inherit'.
danielroe
approved these changes
Mar 4, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 151 151
Branches 35 35
=========================================
Hits 151 151 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
danielroe
changed the title
font-family: inherit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes nuxt-modules/fontaine#155
❓ Type of change
📚 Description
Overriding
font-family: inherittofont-family: inherit, "inherit override"leads to an invalid property value. This occured when using Nuxt (reproduction) but not without it (inside fontaine/playground).The fix is implemented by skipping overrides if the first family is 'inherit' because I assume that only the first family is used to determine the fallback font and there is no need for a separate one if inherits the fallback anyway. Another idea was to filter out 'inherit' like you did with 'var(...' but I think that would lead to it being removed from the entire property value, even if it has no effect on the fallback font.
I was only able to test it by editing the code inside node_modules directly. Would be interesting to know how you would approach fixing this :).
📝 Checklist