feat!: size-adjust metric calculation
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
approved these changes
Jun 8, 2023
danielroe
changed the title
size-adjust metric calculationsize-adjust metric calculation
|
Hi, quick question: Was it intentional to remove the ability to specify multiple fallbacks? Prior to this commit, we could pass in 4913379#diff-9fda4173044ba9935eb8372745516c4f87b84c993369057f66546b231e2e7f78L60 With this PR, that was replaced with a single fallback. |
|
Yes, this is because the size-adjust calculation has to be the ratio between two fonts. I'd be happy accepting an array again, though this would increase the amount of CSS generated. |
|
Got it. Yeah, I think it would be nice for folks who specify a font stack with multiple fallbacks (e.g., capsize has a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.