fix: use random port when port: 0 is set

unjs · Aug 27, 2023 · 081ed99 · 081ed99
1 parent cee453a
commit 081ed99
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -30,16 +30,18 @@ export async function getPort(config: GetPortInput = {}): Promise<PortNumber> {
     config = { port: Number.parseInt(config + "") || 0 };
   }
 
+  const _port = Number(config.port ?? process.env.PORT ?? 3000);
+
   const options = {
     name: "default",
-    random: false,
+    random: _port === 0,
     ports: [],
     portRange: [],
     alternativePortRange: config.port ? [] : [3000, 3100],
     host: undefined,
     verbose: false,
     ...config,
-    port: config.port || Number.parseInt(process.env.PORT || "") || 3000,
+    port: _port,
   } as GetPortOptions;
 
   if (options.random) {

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -64,10 +64,20 @@ describe("getPort (host)", () => {
   });
 });
 
-describe("getPort (random)", () => {
-  test('getRandomPort', async () => {
+describe("getPort: random", () => {
+  test("{ random: true }", async () => {
     const port = await getPort({ random: true });
     expect(typeof port).toBe("number");
     expect(port).not.toBe(3000);
-  })
-})
+  });
+
+  test("{ port: 0 }", async () => {
+    let port = await getPort({ port: 0 });
+    expect(typeof port).toBe("number");
+    expect(port).not.toBe(3000);
+
+    port = await getPort({ port: "0" as any });
+    expect(typeof port).toBe("number");
+    expect(port).not.toBe(3000);
+  });
+});