Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip port on any listen error #61

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: skip port on any listen error #61

merged 1 commit into from
Sep 6, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 6, 2023

  • test: skip invalid host tests on windows
  • style: lint
  • fix: skip all listen errors

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Previously we were silently ignoring some specific listen errors (EINVAL and EADDRNOTAVAIL) mainly due to windows IPv6 issues. Now that error handling is better, i think it makes sense to avoid this and find and fix and possible root causes

(if this PR might introduce any regressions, i really apologize, please ping me in an issue to quickly check and fix!)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: skip port on any invalid host error fix: skip port on any listen error Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #61 (990f1d5) into main (1501204) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   85.13%   85.20%   +0.07%     
==========================================
  Files           5        5              
  Lines         370      365       -5     
  Branches       48       47       -1     
==========================================
- Hits          315      311       -4     
+ Misses         55       54       -1     
Files Changed Coverage Ξ”
src/_internal.ts 85.88% <100.00%> (+0.32%) ⬆️

@pi0 pi0 merged commit 629c162 into main Sep 6, 2023
4 checks passed
@pi0 pi0 deleted the fix/no-invalid-host branch September 6, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant