Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer explicit port/portRange even if random: true is passed #65

Closed
davidfirst opened this issue Sep 29, 2023 · 1 comment
Closed

prefer explicit port/portRange even if random: true is passed #65

davidfirst opened this issue Sep 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@davidfirst
Copy link

davidfirst commented Sep 29, 2023 •
edited
Loading

Environment

Mac, node 18.

Reproduction

await p.getPort({ random: true, portRange: [5000, 6000]  });

output:

63493

Describe the bug

I get number that are not part of the specified range. (I tried also alternativePortRange, same issue).
@davidfirst davidfirst changed the title Random is not really random Random option ignores the portRange Sep 29, 2023
@davidfirst davidfirst changed the title Random option ignores the portRange The "random" option ignores the "portRange" option Sep 29, 2023
@pi0 pi0 changed the title The "random" option ignores the "portRange" option prefer explicit port/portRange even if random: true` is passed Oct 2, 2023
@pi0 pi0 added the enhancement New feature or request label Oct 2, 2023
@pi0 pi0 changed the title prefer explicit port/portRange even if random: true` is passed prefer explicit port/portRange even if random: true is passed Oct 2, 2023
@peterroe peterroe mentioned this issue Oct 22, 2023
Closed
8 tasks
@pi0 pi0 closed this as completed in cd4acec Jan 9, 2024
@pi0
Copy link
Member

pi0 commented Jan 9, 2024

Thanks for report. Should be resolved by cd4acec in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidfirst @pi0