fix: explicit port/portRange even if random is true
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterroe
changed the title
port/portRange even if randon is trueport/portRange even if random is true
pi0
reviewed
Oct 23, 2023
| const j = Math.floor(Math.random() * (i + 1)); | ||
| [r[i], r[j]] = [r[j], r[i]]; | ||
| } | ||
| } |
There was a problem hiding this comment.
We should depend on OS behavior for choosing a random port.
There was a problem hiding this comment.
I tried to find a solution but I failed
The port exposed by net.createServer().listen(0) depends on the internal method of node. https://github.com/nodejs/node/blob/04f9385311d7bc7df0beabf10541e599c2592c6f/lib/net.js#L1924-L1934
There seems to be no good way to have the system randomly select a port within a certain range
And I tried calling the listen(0) method countless times, but the returned random port still failed to hit a certain range that I wanted.
|
Thanks for PR. linked issue should be resolved by cd4acec in next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#65
❓ Type of change
📚 Description
📝 Checklist