-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use closed ranges as port ranges (and some docs fixes) #66
Conversation
df13601
to
e8c210f
Compare
Currently, the library silently considers a range as an empty one if the range's start is greater or equal than its end. A couple of questions/ideas:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π―
Sure ππΌ While it is a slight behavior change, i think it would be harmless to have as a fix. Do you mind to include it in same PR as a fix? ππΌ
It is little necessary complexity in implementation IMO. Any specific reason to do it? |
Sure! I'll update the PR soon.
No, there is no specific reason for doing that :) A reverse-ordered array can easily be created in the code and passed as a |
085510a
to
6255565
Compare
Hi @pi0! What would be the next steps to get this merged? There is one workflow awaiting approval from a maintainer. Could you help me with that, please? Thank you! :) |
π Linked issue
None.
β Type of change
π Description
README.md
._generateRange
internal helpers.π Checklist