Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ranges now work even if port is unset in options #72

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

filiphazardous
Copy link
Contributor

@filiphazardous filiphazardous commented Nov 8, 2023

πŸ”— Linked issue

resolves #67

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Moved default port to the end of the queue of ports to check (instead of the head of the
queue, as previously).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@filiphazardous
Copy link
Contributor Author

@pi0 Any feedback on this?

@AndersCV
Copy link

Bump. Possible to get this PR looked at?

@pi0 pi0 merged commit 2586218 into unjs:main Jan 9, 2024
2 checks passed
@pi0
Copy link
Member

pi0 commented Jan 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

options.port default to 3000, even in the presence of options.ports
3 participants