fix: enable debug by default

unjs · Dec 5, 2020 · 010cdfe · 010cdfe
1 parent d1ea877
commit 010cdfe
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/src/app.ts b/src/app.ts
@@ -12,7 +12,7 @@ export function createApp (options: AppOptions = {}): App {
   // @ts-ignore
   const app: Partial<App> = function (req: IncomingMessage, res: ServerResponse) {
     return _handle(req, res)
-      .catch((err: Error | any) => { sendError(res, err, options.debug) })
+      .catch((err: Error | any) => { sendError(res, err, undefined, options.debug) })
   }
 
   app.stack = stack

diff --git a/src/utils.ts b/src/utils.ts
@@ -17,7 +17,7 @@ export function defaultContentType (res: ServerResponse, type: string) {
   }
 }
 
-export function sendError (res: ServerResponse, error: Error | string, debug?: boolean, code?: number) {
+export function sendError (res: ServerResponse, error: Error | string, code?: number, debug: boolean = true) {
   res.statusCode = code ||
     (res.statusCode !== 200 && res.statusCode) ||
     // @ts-ignore

diff --git a/test/app.test.ts b/test/app.test.ts
@@ -6,7 +6,7 @@ describe('app', () => {
   let request: SuperTest<Test>
 
   beforeEach(() => {
-    app = createApp()
+    app = createApp({ debug: false })
     request = supertest(app)
   })
 

diff --git a/test/e2e.test.ts b/test/e2e.test.ts
@@ -10,7 +10,7 @@ describe('server', () => {
   let server: Server
 
   beforeEach(async () => {
-    app = createApp()
+    app = createApp({ debug: false })
     server = new Server(app)
     const port = await getPort()
     server.listen(port)

diff --git a/test/integrations.test.ts b/test/integrations.test.ts
@@ -9,7 +9,7 @@ describe('integrations with other frameworks', () => {
   let request: SuperTest<Test>
 
   beforeEach(() => {
-    app = createApp()
+    app = createApp({ debug: false })
     request = supertest(app)
   })
 

diff --git a/test/lazy.test.ts b/test/lazy.test.ts
@@ -8,7 +8,7 @@ describe('lazy loading', () => {
   let request: SuperTest<Test>
 
   beforeEach(() => {
-    app = createApp()
+    app = createApp({ debug: false })
     request = supertest(app)
   })
 

diff --git a/test/utils.test.ts b/test/utils.test.ts
@@ -8,7 +8,7 @@ describe('', () => {
   let request: SuperTest<Test>
 
   beforeEach(() => {
-    app = createApp()
+    app = createApp({ debug: false })
     request = supertest(app)
   })
 
@@ -24,7 +24,7 @@ describe('', () => {
 
   describe('sendError', () => {
     it('logs errors', async () => {
-      app.use((_req, res) => sendError(res, 'Unprocessable', undefined, 422))
+      app.use((_req, res) => sendError(res, 'Unprocessable', 422))
       const result = await request.get('/')
 
       expect(result.status).toBe(422)
@@ -33,14 +33,14 @@ describe('', () => {
 
   describe('sendError', () => {
     it('returns errors', async () => {
-      app.use((_req, res) => sendError(res, 'Unprocessable', undefined, 422))
+      app.use((_req, res) => sendError(res, 'Unprocessable', 422))
       const result = await request.get('/')
 
       expect(result.status).toBe(422)
     })
 
     it('logs errors in debug mode', async () => {
-      app.use((_req, res) => sendError(res, 'Unprocessable', true, 422))
+      app.use((_req, res) => sendError(res, 'Unprocessable', 422, true))
       const result = await request.get('/')
 
       expect(result.status).toBe(422)