fix(sendRedirect): always encode location uri

unjs · Aug 30, 2022 · 01476ac · 01476ac · MurmeltierS · Sep 1, 2022
1 parent 2fa27e6
commit 01476ac
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/utils/response.ts b/src/utils/response.ts
@@ -24,13 +24,14 @@ export function defaultContentType (event: CompatibilityEvent, type?: string) {
 }
 
 export function sendRedirect (event: CompatibilityEvent, location: string, code = 302) {
+  const encodedLoc = encodeURI(location)
   event.res.statusCode = code
-  event.res.setHeader('Location', location)
-  // minimal html document that redirects on client side
+  event.res.setHeader('Location', encodedLoc)
+  // Minimal html document that redirects on client side
   const html = `<!DOCTYPE html>
 <html>
-  <head><meta http-equiv="refresh" content="0; url=${encodeURI(location)}"></head>
-  <body>Redirecting to <a href=${JSON.stringify(location)}>${encodeURI(location)}</a></body>
+  <head><meta http-equiv="refresh" content="0; url=${encodedLoc}"></head>
+  <body>Redirecting to <a href=${JSON.stringify(encodedLoc)}>${encodedLoc}</a></body>
 </html>`
   return send(event, html, MIMES.html)
 }