Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router issue with query params #77

Closed
pi0 opened this issue Mar 28, 2022 · 2 comments
Closed

router issue with query params #77

pi0 opened this issue Mar 28, 2022 · 2 comments
Assignees
@pi0
Labels
bug Something isn't working

Comments

@pi0
Copy link
Member

pi0 commented Mar 28, 2022

@pi0 Hello, Thank you very much createRouter for solving my problem. I used the add function to successfully add a route for a get request, and it works normally, but if I add a query parameter after the URL, such as /a?title=a, Such a route will fail to match;

Originally posted by @1018715564 in #76 (comment)
@pi0 pi0 added the bug Something isn't working label Mar 28, 2022
@pi0 pi0 self-assigned this Mar 28, 2022
@pi0 pi0 mentioned this issue Mar 28, 2022
Closed
seho-dev added a commit to seho-dev/h3 that referenced this issue Mar 29, 2022
@seho-dev
fix: router issue with query params unjs#77
ccd78b2
seho-dev added a commit to seho-dev/h3 that referenced this issue Mar 29, 2022
@seho-dev
fix: router issue with query params (unjs#77)
798369e
@seho-dev
Copy link
Contributor

@pi0

pi0 added a commit that referenced this issue Mar 29, 2022
@seho-dev @pi0
fix: router issue with query params (#77) (#78)
229964e 
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
@pi0
Copy link
Member Author

pi0 commented Mar 31, 2022

Solved by #78

@pi0 pi0 closed this as completed Mar 31, 2022
@brtinney brtinney mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pi0 pi0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pi0 @seho-dev