Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split set-cookie value when handling web responses #445

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: split set-cookie value when handling web responses #445

merged 1 commit into from
Jul 17, 2023

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Jul 17, 2023 •
edited

🔗 Linked issue

Resolves #439

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Hebilicious Hebilicious added the enhancement New feature or request label Jul 17, 2023
@Hebilicious Hebilicious requested a review from pi0 July 17, 2023 09:25
@pi0 pi0 changed the title feat: support set-cookie in WebResponse fix: split set-cookie value when handling web responses Jul 17, 2023
@pi0 pi0 merged commit edeb5dc into main Jul 17, 2023
4 checks passed
@pi0 pi0 deleted the set-cookie-web-response branch July 17, 2023 13:25
@Hebilicious Hebilicious mentioned this pull request Jul 19, 2023
Closed
@pi0 pi0 mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle cookies with Response
2 participants
@Hebilicious @pi0