Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event): support event.url #455

Merged
merged 1 commit into from
Jul 24, 2023
Merged

feat(event): support event.url #455

merged 1 commit into from
Jul 24, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 24, 2023

πŸ”— Linked issue

Related / Needed by #454

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds event.url with a lazy initializer to access the request URL.

By default, we use getRequestURL with default options (trusts x-forwarded-proto as a boolean and ignores x-forwarded-host)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #455 (f086c69) into main (27a1bd0) will increase coverage by 0.17%.
The diff coverage is 96.22%.

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   77.76%   77.93%   +0.17%     
==========================================
  Files          26       26              
  Lines        2698     2724      +26     
  Branches      399      395       -4     
==========================================
+ Hits         2098     2123      +25     
- Misses        600      601       +1     
Impacted Files Coverage Ξ”
src/utils/request.ts 98.44% <75.00%> (-1.56%) ⬇️
src/event/event.ts 68.12% <95.83%> (+5.80%) ⬆️
src/app.ts 97.68% <100.00%> (+0.05%) ⬆️
src/router.ts 98.47% <100.00%> (-0.03%) ⬇️
src/utils/route.ts 89.47% <100.00%> (+1.97%) ⬆️

@pi0 pi0 merged commit a9b8de8 into main Jul 24, 2023
6 checks passed
@pi0 pi0 deleted the feat/event-url branch July 24, 2023 16:55
@pi0 pi0 mentioned this pull request Aug 4, 2023
@ineshbose
Copy link

Hi, was this change included in the latest release? I can't seem to access/find it. πŸ˜…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants