Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add polyfills to run all tests against node.js 16 #456

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 24, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Node.js 16 is still in LTS-supported mode till Sep this year and we might need to support it for a little bit longer. While it hurts, we need to make sure it is supported until then (via polyfills at least)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title test: enable polyfills for node 16 test: add polyfills to run all tests against node.js 16 Jul 24, 2023
@pi0 pi0 merged commit 591836e into main Jul 24, 2023
4 checks passed
@pi0 pi0 deleted the test/node-16-compat branch July 24, 2023 17:06
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant