Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(event): use sendWebResponse for event.respondWith #481

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 1, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR deprecates legacy H3Request/H3Headers and uses new sendWebResponse utility for event.respondWith in order to reduce bundle size and uses latest/consistent response handling.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #481 (5fe5904) into main (bc202c0) will increase coverage by 0.94%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   81.30%   82.25%   +0.94%     
==========================================
  Files          28       28              
  Lines        3236     3206      -30     
  Branches      489      489              
==========================================
+ Hits         2631     2637       +6     
+ Misses        605      569      -36     
Files Changed Coverage Ξ”
src/event/event.ts 90.36% <40.00%> (+15.59%) ⬆️
src/utils/response.ts 74.69% <66.66%> (+<0.01%) ⬆️
src/event/index.ts 100.00% <100.00%> (ΓΈ)
src/event/polyfills/headers.ts 42.64% <100.00%> (ΓΈ)
src/event/polyfills/response.ts 38.09% <100.00%> (ΓΈ)

@pi0 pi0 merged commit 21ed8d1 into main Aug 1, 2023
5 of 6 checks passed
@pi0 pi0 deleted the refactor/respond-with branch August 1, 2023 19:37
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant