Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples/from-expressjs-to-h3): add node middleware usage #663

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

markthree
Copy link
Contributor

@markthree markthree commented Feb 24, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I think we can add a guide on using middleware with h3 for users accustomed to Express, which would facilitate their migration.

tip: This is also the confusion I have encountered in actual use; I believe they might face similar issues as well. 🀣

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes Barbapapazes changed the title docs(examples/from-expressjs-to-h3): add Middleware docs(examples/from-expressjs-to-h3): add node middleware usage Feb 24, 2024
@Barbapapazes Barbapapazes added the documentation Improvements or additions to documentation label Feb 24, 2024
@NozomuIkuta NozomuIkuta mentioned this pull request Feb 24, 2024
8 tasks
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pi0 pi0 merged commit ad77c97 into unjs:main Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants