Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow parallel hooks with unique time strings #55

Merged
merged 7 commits into from
Oct 15, 2022
Merged

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe added the bug Something isn't working label Oct 14, 2022
@danielroe danielroe requested a review from pi0 October 14, 2022 11:27
@danielroe danielroe self-assigned this Oct 14, 2022
src/hookable.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #55 (dba471e) into main (f6d4475) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   98.82%   98.84%   +0.02%     
==========================================
  Files           4        4              
  Lines         339      347       +8     
  Branches       88       90       +2     
==========================================
+ Hits          335      343       +8     
  Misses          4        4              
Impacted Files Coverage 螖
src/utils.ts 98.23% <100.00%> (+0.13%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe danielroe requested a review from pi0 October 14, 2022 12:36
@pi0
Copy link
Member

pi0 commented Oct 15, 2022

Had been trying a few ideas last night but seems not easy to cover all cases. Only pushed some small refactors to progress.

FYI, this implementation with has some issues still for tracking parallel hook calls with certain timing cases:

(#id indicates assigned event._id we use to pad and add hidden diff and (!) issue)

#0: |----------------| (logEnd #0)
    ctr=1           ctr=1
#1:     |------------------------| (logEnd #1) (!)
        ctr=2                    ctr=1
#1:                        |----------------------| logEnd(#1) (!)
                           ctr=2                  ctr1=

@pi0
Copy link
Member

pi0 commented Oct 15, 2022

~> #57

@pi0 pi0 merged commit ee64dc8 into main Oct 15, 2022
@pi0 pi0 deleted the fix/parallel-hooks branch October 15, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants