Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shift name out of arg array #71

Merged
merged 5 commits into from Mar 10, 2023
Merged

fix: shift name out of arg array #71

merged 5 commits into from Mar 10, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 10, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Nasty regression from #69. We are passing an a single array. We make our createTask function work by pushing the name into the array and then removing it from the array (to avoid creating a new instance: #69 (comment)).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 10, 2023
@danielroe danielroe requested a review from pi0 March 10, 2023 15:42
@danielroe danielroe self-assigned this Mar 10, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pi0 pi0 merged commit 88f0e96 into main Mar 10, 2023
1 check passed
@pi0 pi0 deleted the fix/arrays branch March 10, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants