Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default 300 maxAge for http adapter #197

Merged
merged 1 commit into from Jan 11, 2024
Merged

Conversation

jameswragg
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The README specified the IPX_HTTP_MAX_AGE default to be 300 but its never set (as a default).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: missing maxAge default fix: add default 300 maxAge for http adapter Dec 8, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot!

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (fc8a0de) 54.10% compared to head (65be210) 54.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   54.10%   54.10%           
=======================================
  Files          11       11           
  Lines        1083     1083           
  Branches       45       45           
=======================================
  Hits          586      586           
  Misses        497      497           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@jameswragg
Copy link
Contributor Author

FYI @pi0 I don't have merge permissions

@pi0
Copy link
Member

pi0 commented Dec 8, 2023

Yeah will merge once planned for release otherwise will forget about PR :)

@pi0 pi0 merged commit d51e700 into unjs:main Jan 11, 2024
4 checks passed
@jameswragg jameswragg deleted the patch-1 branch April 23, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants