New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node-fs): add support for multiple dirs #203
feat(node-fs): add support for multiple dirs #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this β€οΈ
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 53.61% 56.02% +2.40%
==========================================
Files 14 14
Lines 1188 1203 +15
Branches 66 83 +17
==========================================
+ Hits 637 674 +37
+ Misses 548 526 -22
Partials 3 3 β View full report in Codecov by Sentry. |
Re error, i mainly used new codes for each driver to make debugging easier against user setups. |
Thanks again! I have pushed few refactors to make it mergable hope you are happy with them and any PR more than welcome to improve β€οΈ |
Thank you! I love how you used scoped I'll push updates to nuxt/image#1177 |
π Linked issue
nuxt/image#1177
β Type of change
π Description
As discussed, add support for serving files from multiple directories. At the moment of posting this PR the code scans dirs in order and returns first found file, meaning earlier dirs take precedence.
There are no docs in this repository mentioning programatic use of
dir
and the change is backwards compatible.π Checklist