Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
have an addition here for the test, there is still missing the retrieval of an external resource.
The whole thing has now but a background ;) we use in our package
nuxt-speedkit
the@nuxt/image
and can not update here for a long time basics/nuxt-booster#521.This all came with the
ipx
update toohmyfetch
with the includednode-fetch@3
.Could find two problems:
node-fetch
update to version 3 brings errors when calling many requests.This topic can be found here:
- node-fetch/node-fetch#1474
- node-fetch/node-fetch#1325
And can be easily reproduced with the many call to http://localhost:3000/width_200/https://avatars.githubusercontent.com/u/23360933?s=500 in dev mode.
There I get this error message when running
ohmyfetch.fetch
and in worst case asegment fault
jest
.I created a small repo for
ohmyfetch
, in the test you can see that the call has a problem.Therefore, this test will probably not be passed in PR.
Could I run it completely if I replaced
ohmyfetch
withnode-fetch
or changed the import to:In both cases, I had to extend the
jest
configuration withbabel
, becausenode-fetch@3
runs injest
only as ESM (node-fetch/node-fetch#1289) and the node.mjs has to be converted as well.Now I'm asking myself, what's the next step here?
node-fetch@3
update, where one of the given PRs is included.ohmyfetch
in thejest
must work. (rollup issue?)The easiest solution would be to switch back from
ohmyfetch
tonode-fetch@2
.Thanks already for the help :)
unjs/ofetch#57