chore: update repo #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please check CI/lint issue? |
NozomuIkuta
commented
Mar 6, 2023
| function genRawValue (value: unknown, indent = ""): string { | ||
| if (typeof value === "undefined") { | ||
| function genRawValue(value: unknown, indent = ""): string { | ||
| if (typeof value === "undefined" || value === undefined) { |
There was a problem hiding this comment.
I added value === undefined condition, othewise value can't be type-narrowed at the point of value.toString().
There was a problem hiding this comment.
I don't know why, but TypeScript seems to not type-narrow value with typeof x === "undefined" condition.
Since it passes unit tests, let me merge this PR for now.
But, please be aware that I included code change in this PR as well as applying the latest template. 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to work on #24, but first I applied the latest unjs template for maintenance.