Skip to content

Commit

Permalink
chore: remove ws from shared args for now
Browse files Browse the repository at this point in the history
  • Loading branch information
@pi0
pi0 committed Jan 29, 2024
1 parent 207e882 commit d115045
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/cli.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ export const main = defineCommand({
description: "Watch for changes",
alias: "w",
},
ws: {
type: "boolean",
description: "Enable Experimental WebSocket support",
},
...getArgs(),
},
async run({ args }) {
Expand Down Expand Up @@ -86,10 +90,6 @@ export function getArgs() {
type: "boolean",
description: "Open the URL in the browser",
},
ws: {
type: "boolean",
description: "Enable Experimental WebSocket support",
},
https: {
type: "boolean",
description: "Enable HTTPS",
Expand Down

5 comments on commit d115045

@kashalls
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pi0 Was this blocking v1.6.0 or was listhen + crossws not working?

@pi0
Copy link
Member Author

@pi0 pi0 commented on d115045 Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically it should be opt-in (implemented) in CLIs that use the future. Only built-ion CLI currently implements it as experimental.

@kashalls
Copy link

@kashalls kashalls commented on d115045 Feb 22, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically it should be opt-in (implemented) in CLIs that use the future. Only built-ion CLI currently implements it as experimental.

I see. I was hoping to be able to test this functionality, but seeing how nitro doesn't fetch those args I can't get it to work. Is there a way to implement this functionality outside of the listhen cli and in nitro for the meantime?

@pi0
Copy link
Member Author

@pi0 pi0 commented on d115045 Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on it ;)

@kashalls
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on it ;)

Thank you! I appreciate it. Feel free to mention me or in the Nuxtjs discord for help/debugging/testing.

Please sign in to comment.