Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support websocket upgrade listener #128

Closed
wants to merge 6 commits into from
Closed

Conversation

nksaraf
Copy link

@nksaraf nksaraf commented Sep 24, 2023

Add websocket support for listhen by adding a ws option. its enabled by default.

We enable websockets by adding an on('upgrade') handler that calls our handle function (node listener) and gives you a change to upgrade it in your handler.

The actual upgrade is the responsibility of the handler, this just makes it possible to do with the cli and everything

@nksaraf nksaraf changed the title add websocket support add websocket upgrade listener Sep 24, 2023
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (8b873f0) 52.19% compared to head (83f1675) 51.18%.
Report is 8 commits behind head on main.

❗ Current head 83f1675 differs from pull request most recent head e4d8568. Consider uploading reports for the commit e4d8568 to get more accurate results

Files Patch % Lines
playground/index.ts 0.00% 35 Missing ⚠️
src/cli.ts 0.00% 6 Missing ⚠️
src/listen.ts 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   52.19%   51.18%   -1.02%     
==========================================
  Files          17       17              
  Lines        1686     1733      +47     
  Branches      145      147       +2     
==========================================
+ Hits          880      887       +7     
- Misses        801      841      +40     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 changed the title add websocket upgrade listener feat: support websocket upgrade listener Dec 5, 2023
@pi0
Copy link
Member

pi0 commented Jan 29, 2024

thanks for initial efforts. i will rework it with crossws

@pi0 pi0 closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants