Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple glob patterns #41

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

dwightjack
Copy link
Contributor

This PR iterates over #21.

The globby library supports an array with multiple globs as its first argument, and mri already supports multiple inputs for a flag (--pattern=aaa --pattern=bbb --> pattern: ['aaa', 'bbb']).

Adding the ability to pass multiple patterns makes it easier to use negative patterns and create more complex filters.

On the documentation, I am not sure whether the [--pattern=glob [--pattern=more-glob]] signature is correct or if there is a clearer way to express the feature.

@codecov-commenter
Copy link

Codecov Report

Merging #41 (c6206a0) into main (e10e549) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files           6        6           
  Lines         127      127           
  Branches       36       36           
=======================================
  Hits          123      123           
  Misses          4        4           
Impacted Files Coverage Δ
src/make.ts 96.29% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10e549...c6206a0. Read the comment docs.

@dwightjack
Copy link
Contributor Author

Hi folks!

I know you are busy working on the next release of Nuxt, so I am just checking in to know your opinion about this idea.

By the way, if you need help for the maintenance of this (and other) package(s), feel free to ping me 😃 .

@dwightjack
Copy link
Contributor Author

Hi folks!

I know you are busy working on the next release of Nuxt, so I am just checking in to know your opinion about this idea.

By the way, if you need help for the maintenance of this (and other) package(s), feel free to ping me 😃 .

Sorry, just checking about the status of this PR. Is there any blocker for it to be merged and released? Let me know if I can help in any way 😄

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title Support multiple glob patterns feat: support multiple glob patterns Oct 27, 2022
@pi0 pi0 merged commit b339163 into unjs:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants