feat: add array type for pattern and copyFile in stream #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markthree
changed the title
pi0
reviewed
Oct 27, 2022
|
|
||
| export const copyFileInStream = (srcPath: string, outPath: string) => { | ||
| const srcStream = createReadStream(srcPath) | ||
| const outStream = createWriteStream(outPath, { encoding: 'utf-8' }) |
There was a problem hiding this comment.
I think we can avoid passing encoding, considering some mkdist files might be binary like an image.
There was a problem hiding this comment.
This is really something I didn't pay attention to
|
Hi dear @markthree. Support for multiple glob patterns added via #41. If you like to, would be happy to accept a new PR to improve copy performance by using streams. |
Good idea. I'll finish it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 The Globby supports
string[]，and using streams for copy can support large files