Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support postcss loader #167

Merged
merged 13 commits into from
Nov 22, 2023
Merged

feat: support postcss loader #167

merged 13 commits into from
Nov 22, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 20, 2023

πŸ”— Linked issue

Resolves #166

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

TODO: Before introducing this feature i am thinking to make the plugins configurable and (some?) opt-in.

Beta testing: Add this to package.json and run install command. It should work directly for mkdist and also for unbuild, nuxt-module-builder, etc.

  "resolutions": {
    "mkdist": "npm:@pi0/mkdist@1.4.0-rc.2"
  },

Thoughts welcome πŸ‘πŸΌ

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

pi0 and others added 3 commits July 20, 2023 11:36
Co-authored-by: adbmx-glitch <adbmx-glitch@users.noreply.github.com>
@pi0 pi0 requested a review from danielroe November 6, 2023 11:43
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

@pi0 pi0 marked this pull request as ready for review November 22, 2023 13:08
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e7d3ffb) 95.99% compared to head (145b6e8) 96.06%.

❗ Current head 145b6e8 differs from pull request most recent head c31635d. Consider uploading reports for the commit c31635d to get more accurate results

Files Patch % Lines
src/loaders/index.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   95.99%   96.06%   +0.06%     
==========================================
  Files           8        9       +1     
  Lines         574      635      +61     
  Branches      102      115      +13     
==========================================
+ Hits          551      610      +59     
- Misses         23       25       +2     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title feat: add postcss loader feat: support postcss loader Nov 22, 2023
@pi0 pi0 merged commit 30530ab into main Nov 22, 2023
2 checks passed
@pi0 pi0 deleted the feat/postcss branch November 22, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postcss loader support
2 participants