Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support vue-tsc v2 #201

Merged
merged 8 commits into from Apr 25, 2024
Merged

feat: support vue-tsc v2 #201

merged 8 commits into from Apr 25, 2024

Conversation

aa900031
Copy link
Contributor

@aa900031 aa900031 commented Mar 10, 2024

πŸ”— Linked issue

closes #199

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

A few days ago, vue/language-tools updated its main version to 2.x.x, and vue-tac no longer provides the createProgram function in v2, so it needs to be rewritten to be used.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 April 25, 2024 11:06
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 86.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 80.12%. Comparing base (9000888) to head (2b321b2).
Report is 8 commits behind head on main.

❗ Current head 2b321b2 differs from pull request most recent head e1e3f46. Consider uploading reports for the commit e1e3f46 to get more accurate results

Files Patch % Lines
src/utils/vue-dts.ts 86.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   82.86%   80.12%   -2.74%     
==========================================
  Files          12       12              
  Lines         852      931      +79     
  Branches      133      144      +11     
==========================================
+ Hits          706      746      +40     
- Misses        144      183      +39     
  Partials        2        2              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 merged commit ad36d7b into unjs:main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants