Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lookupNodeModuleSubpath): handle conditions and nested exports #210

Merged
merged 9 commits into from Jan 11, 2024

Conversation

productdevbook
Copy link
Contributor

@productdevbook productdevbook commented Dec 26, 2023

issua: #209

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

- Expected
+ Received

- import
+ bun

In package json the paths to bun and import are the same, but you don't have a bun file and you don't have a ts file. Therefore this output /../node_modules/.pnpm/postgres@3.4.3/node_modules/postgres/bun' is wrong. it should give the import path instead of bun.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (5213717) 86.98% compared to head (fc2f980) 87.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   86.98%   87.10%   +0.12%     
==========================================
  Files           8        8              
  Lines        1037     1039       +2     
  Branches      168      172       +4     
==========================================
+ Hits          902      905       +3     
+ Misses        135      134       -1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title chore: add graphql lookupNodeModuleSubpath test fix(lookupNodeModuleSubpath): skip export conditions as subpath Jan 11, 2024
@pi0 pi0 changed the title fix(lookupNodeModuleSubpath): skip export conditions as subpath fix(lookupNodeModuleSubpath): handle conditions and nested exports Jan 11, 2024
@pi0 pi0 marked this pull request as ready for review January 11, 2024 13:32
@pi0
Copy link
Member

pi0 commented Jan 11, 2024

Thanks for reproduction dear @productdevbook. I have pushed fixes on top of it πŸ‘πŸΌ

@pi0
Copy link
Member

pi0 commented Jan 11, 2024

Followup: #218

@pi0 pi0 merged commit 4cb88e5 into unjs:main Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants