Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add type safety to auto-detected providers #1072

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds type-safety for auto-detected providers.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 21, 2023
@danielroe danielroe requested a review from pi0 March 21, 2023 15:30
@danielroe danielroe self-assigned this Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1072 (46515c9) into main (7ae95d2) will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
+ Coverage   67.32%   67.34%   +0.02%     
==========================================
  Files          62       62              
  Lines        6292     6297       +5     
  Branches      707      707              
==========================================
+ Hits         4236     4241       +5     
  Misses       2042     2042              
  Partials       14       14              
Impacted Files Coverage Ξ”
src/utils/index.ts 50.45% <42.85%> (+0.90%) ⬆️
src/options.ts 87.53% <66.66%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: add type safety to auto-detected providers refactor: add type safety to auto-detected providers Mar 22, 2023
@pi0 pi0 merged commit 246ba03 into main Mar 22, 2023
@pi0 pi0 deleted the fix/typed-providers branch March 22, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants