Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate typesDir from tsConfigDir #1146

Merged
merged 2 commits into from
Apr 16, 2023
Merged

fix: separate typesDir from tsConfigDir #1146

merged 2 commits into from
Apr 16, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This fixes a regression where we were expecting the tsConfigPath passed in to be a child of types, and therefore produce the wrong paths within a generated tsconfig.json.

It also adds a new forceConsistentCasingInFileNames option, and allows configuring of the strict option (disabled by default to avoid a breaking change, although I would recommend always enabling strict mode, and perhaps this could be made default in a future version).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 15, 2023
@danielroe danielroe requested a review from pi0 April 15, 2023 22:06
@danielroe danielroe self-assigned this Apr 15, 2023
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #1146 (d9b86fb) into main (e656948) will increase coverage by 0.07%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
+ Coverage   67.71%   67.79%   +0.07%     
==========================================
  Files          66       66              
  Lines        6493     6487       -6     
  Branches      718      718              
==========================================
+ Hits         4397     4398       +1     
+ Misses       2081     2074       -7     
  Partials       15       15              
Impacted Files Coverage Ξ”
src/build.ts 42.85% <5.26%> (+0.58%) ⬆️
src/options.ts 87.73% <100.00%> (+0.03%) ⬆️
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 861ede9 into main Apr 16, 2023
@pi0 pi0 deleted the fix/types-dir branch April 16, 2023 12:25
@pi0 pi0 mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants